Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Adds a11y tests for categorization and recognizer job wizards #162126

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

peteharverson
Copy link
Contributor

@peteharverson peteharverson commented Jul 18, 2023

Summary

Adds accessibility tests for the categorization and data recognizer anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection pages into a separate file as the original ml.ts file was getting very large.

Part of #160712
Part of #88496

Checklist

@peteharverson peteharverson added :ml release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.10.0 labels Jul 18, 2023
@peteharverson peteharverson self-assigned this Jul 18, 2023
@peteharverson peteharverson requested a review from a team as a code owner July 18, 2023 10:55
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 3.4MB 3.4MB +201.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @peteharverson

@qn895
Copy link
Member

qn895 commented Jul 18, 2023

LGTM 🎉

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peteharverson peteharverson merged commit 46403f1 into elastic:main Jul 19, 2023
@kibanamachine kibanamachine added the backport:skip This commit does not require backporting label Jul 19, 2023
@peteharverson peteharverson deleted the ml-add-ad-a11y-tests branch July 19, 2023 13:03
Ruhshan pushed a commit to Ruhshan/kibana that referenced this pull request Jul 19, 2023
…lastic#162126)

## Summary

Adds accessibility tests for the categorization and data recognizer
anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection
pages into a separate file as the original `ml.ts` file was getting very
large.

Part of elastic#160712
Part of elastic#88496

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
ThomThomson pushed a commit to ThomThomson/kibana that referenced this pull request Aug 1, 2023
…lastic#162126)

## Summary

Adds accessibility tests for the categorization and data recognizer
anomaly detection job wizards.

As part of this PR I have split out the tests for the anomaly detection
pages into a separate file as the original `ml.ts` file was getting very
large.

Part of elastic#160712
Part of elastic#88496

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:skip This commit does not require backporting :ml release_note:skip Skip the PR/issue when compiling release notes test-coverage issues & PRs for improving code test coverage v8.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants