-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Adds a11y tests for categorization and recognizer job wizards #162126
Merged
peteharverson
merged 2 commits into
elastic:main
from
peteharverson:ml-add-ad-a11y-tests
Jul 19, 2023
Merged
[ML] Adds a11y tests for categorization and recognizer job wizards #162126
peteharverson
merged 2 commits into
elastic:main
from
peteharverson:ml-add-ad-a11y-tests
Jul 19, 2023
+710
−496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
:ml
release_note:skip
Skip the PR/issue when compiling release notes
test-coverage
issues & PRs for improving code test coverage
v8.10.0
labels
Jul 18, 2023
Pinging @elastic/ml-ui (:ml) |
This was referenced Jul 18, 2023
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
qn895
approved these changes
Jul 18, 2023
LGTM 🎉 |
jgowdyelastic
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ruhshan
pushed a commit
to Ruhshan/kibana
that referenced
this pull request
Jul 19, 2023
…lastic#162126) ## Summary Adds accessibility tests for the categorization and data recognizer anomaly detection job wizards. As part of this PR I have split out the tests for the anomaly detection pages into a separate file as the original `ml.ts` file was getting very large. Part of elastic#160712 Part of elastic#88496 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
ThomThomson
pushed a commit
to ThomThomson/kibana
that referenced
this pull request
Aug 1, 2023
…lastic#162126) ## Summary Adds accessibility tests for the categorization and data recognizer anomaly detection job wizards. As part of this PR I have split out the tests for the anomaly detection pages into a separate file as the original `ml.ts` file was getting very large. Part of elastic#160712 Part of elastic#88496 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
:ml
release_note:skip
Skip the PR/issue when compiling release notes
test-coverage
issues & PRs for improving code test coverage
v8.10.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds accessibility tests for the categorization and data recognizer anomaly detection job wizards.
As part of this PR I have split out the tests for the anomaly detection pages into a separate file as the original
ml.ts
file was getting very large.Part of #160712
Part of #88496
Checklist